chore: ComposeStabilityAnalyzerInitializer 추가 #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release 환경에서 Recomposition 추적 로그가 출력되지 않도록 설정
WalkthroughCompose Stability Analyzer 로깅을 디버그 환경에서만 활성화하기 위해 Android Startup 초기화자를 도입합니다. AndroidManifest.xml에 메타데이터를 추가하고 ComposeStabilityAnalyzerInitializer 클래스를 구현하여 앱 시작 시 초기화합니다. Changes
Sequence DiagramsequenceDiagram
participant App as App Startup
participant Startup as Startup Framework
participant Initializer as ComposeStabilityAnalyzerInitializer
participant Analyzer as ComposeStabilityAnalyzer
App->>Startup: Initialization begins
Startup->>Initializer: create(context)
activate Initializer
Initializer->>Analyzer: setEnabled(BuildConfig.DEBUG)
activate Analyzer
Analyzer-->>Initializer: configured
deactivate Analyzer
Initializer-->>Startup: initialization complete
deactivate Initializer
Startup-->>App: ready
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/src/main/kotlin/com/ninecraft/booket/initializer/ComposeStabilityAnalyzerInitializer.kt (1)
8-16: LGTM! 구현이 PR 목표를 정확히 달성합니다.
BuildConfig.DEBUG를 사용하여 디버그 빌드에서만 Compose Stability Analyzer를 활성화하는 로직이 올바르게 구현되었습니다. 이를 통해 release 빌드에서는 리컴포지션 추적 로그가 출력되지 않습니다.선택사항: 클래스 문서화 추가
가독성 향상을 위해 클래스에 KDoc 주석을 추가하는 것을 고려해보세요:
+/** + * Compose Stability Analyzer를 초기화하는 Startup Initializer. + * Debug 빌드에서만 Compose 리컴포지션 추적 로그를 활성화합니다. + */ class ComposeStabilityAnalyzerInitializer : Initializer<Unit> {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/src/main/AndroidManifest.xml(1 hunks)app/src/main/kotlin/com/ninecraft/booket/initializer/ComposeStabilityAnalyzerInitializer.kt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Compose Stability Check
- GitHub Check: ci-build
🔇 Additional comments (1)
app/src/main/AndroidManifest.xml (1)
48-50: LGTM! 초기화자 등록이 올바르게 추가되었습니다.ComposeStabilityAnalyzerInitializer를 InitializationProvider에 등록하는 meta-data 엔트리가 기존 초기화자들과 동일한 패턴으로 올바르게 추가되었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 설명
🧪 테스트 내역 (선택)
💬 추가 설명 or 리뷰 포인트 (선택)
원인을 확인해보면(진짜 문제가 맞는지) 좋을 것 같습니다.
-> user/me api에 DTO에
notificationEnabled가 추가되어 발생하는 문제 같네요Summary by CodeRabbit
릴리스 노트